Skip to content

test(site): a site without a waitlist link passes the waitlist link test - #756

Merged
pbertsch merged 1 commit into
mainfrom
test/waitlist-links-optional
Nov 17, 2026
Merged

pbertsch merged 1 commit into
mainfrom
test/waitlist-links-optional

Conversation

@pbertsch

Copy link
Copy Markdown
Member

Summary

TestEveryWaitlistLinkPointsToAValidTarget (from #752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page.

The test still checks every waitlist link that exists: each must go to mailto:support@alphawavesystems.com or to #waitlist. A site with no waitlist link now passes. If the scan finds no links at all, siteLinks already catches it in TestEveryApplyLinkPointsToAValidTarget.

This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from #752 is still true.

Mutation check

The two waitlist mutants from #752 are still killed. Each was applied to pricing.astro on main, the test run, and the file restored byte for byte.

Broken rule Result
a waitlist link to another page killed
the waitlist email to another address killed

Test plan

  • The site's form and link tests in go test ./scripts/ pass on main.
  • The same tests pass on the pricing rewrite's pages (no waitlist link) with main's docs and issue templates.
  • gofmt clean.

@pbertsch
pbertsch requested a review from a team as a code owner November 17, 2026 04:33
@pbertsch
pbertsch merged commit f9fe5b2 into main Nov 17, 2026
10 of 11 checks passed
jay23606 added a commit to jay23606/flutter-probe that referenced this pull request Nov 17, 2026
…est (AlphaWaveSystems#756)

## Summary

`TestEveryWaitlistLinkPointsToAValidTarget` (from AlphaWaveSystems#752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page.

The test still checks every waitlist link that exists: each must go to `mailto:support@alphawavesystems.com` or to `#waitlist`. A site with no waitlist link now passes. If the scan finds no links at all, `siteLinks` already catches it in `TestEveryApplyLinkPointsToAValidTarget`.

This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from AlphaWaveSystems#752 is still true.

## Mutation check

The two waitlist mutants from AlphaWaveSystems#752 are still killed. Each was applied to `pricing.astro` on main, the test run, and the file restored byte for byte.

| Broken rule | Result |
|---|---|
| a waitlist link to another page | killed |
| the waitlist email to another address | killed |

## Test plan

- [x] The site's form and link tests in `go test ./scripts/` pass on main.
- [x] The same tests pass on the pricing rewrite's pages (no waitlist link) with main's docs and issue templates.
- [x] `gofmt` clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant