Repository navigation
test(site): a site without a waitlist link passes the waitlist link test - #756
Merged
Merged
Conversation
jay23606
added a commit
to jay23606/flutter-probe
that referenced
this pull request
Nov 17, 2026
…est (AlphaWaveSystems#756) ## Summary `TestEveryWaitlistLinkPointsToAValidTarget` (from AlphaWaveSystems#752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page. The test still checks every waitlist link that exists: each must go to `mailto:support@alphawavesystems.com` or to `#waitlist`. A site with no waitlist link now passes. If the scan finds no links at all, `siteLinks` already catches it in `TestEveryApplyLinkPointsToAValidTarget`. This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from AlphaWaveSystems#752 is still true. ## Mutation check The two waitlist mutants from AlphaWaveSystems#752 are still killed. Each was applied to `pricing.astro` on main, the test run, and the file restored byte for byte. | Broken rule | Result | |---|---| | a waitlist link to another page | killed | | the waitlist email to another address | killed | ## Test plan - [x] The site's form and link tests in `go test ./scripts/` pass on main. - [x] The same tests pass on the pricing rewrite's pages (no waitlist link) with main's docs and issue templates. - [x] `gofmt` clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestEveryWaitlistLinkPointsToAValidTarget(from #752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page.The test still checks every waitlist link that exists: each must go to
mailto:support@alphawavesystems.comor to#waitlist. A site with no waitlist link now passes. If the scan finds no links at all,siteLinksalready catches it inTestEveryApplyLinkPointsToAValidTarget.This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from #752 is still true.
Mutation check
The two waitlist mutants from #752 are still killed. Each was applied to
pricing.astroon main, the test run, and the file restored byte for byte.Test plan
go test ./scripts/pass on main.gofmtclean.