Skip to content

feat(site): a design partner application form, and one way to apply on every page - #752

Merged
pbertsch merged 3 commits into
mainfrom
feat/design-partner-apply
Nov 17, 2026
Merged

pbertsch merged 3 commits into
mainfrom
feat/design-partner-apply

Conversation

@pbertsch

@pbertsch pbertsch commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR adds a design partner application form and makes every page offer the same two ways to apply.

  • .github/ISSUE_TEMPLATE/design-partner.yml: a GitHub issue form, "Design partner application", with the label design-partner. Its fields:

    • team name (required)
    • GitHub owner of the repository (required)
    • CI provider: GitHub Actions or Other (required; its hint says the upload client is built for GitHub Actions runs, since the service is not live)
    • device types: Android emulator, iOS simulator, physical device
    • what you test today (required)
    • contact email (optional)

    It opens with a warning that the issue is public and names support@alphawavesystems.com as the private path. The email field repeats that warning.

  • .github/ISSUE_TEMPLATE/config.yml: the template chooser offers the email path as a contact link. Blank issues stay enabled.

  • The apply path is identical everywhere. The pricing page, the Probe Cloud page, the design-partner guide and the Probe Cloud preview docs offer Apply on GitHub (https://github.com/AlphaWaveSystems/flutter-probe/issues/new?template=design-partner.yml) and Apply by email (mailto:support@alphawavesystems.com).

    • The pricing page's "Apply as a design partner" button now opens the form; it used to jump to an anchor on the same page.
    • The two issues/new?title=… links are gone.
    • The offer wording is unchanged.
  • scripts/site_apply_links_test.go (go test ./scripts/) checks:

    • The form follows GitHub's issue-form rules: name, description and body; known field types; unique ids and labels; options on dropdowns and checkboxes.
    • The form carries the label and the fields and required flags above, the CI and device options, and the public warning with the email path.
    • config.yml offers the email path.
    • The form link names a template file that exists.
    • Every link on the site (website/src/pages, website/src/content/docs) whose text says "apply" goes to one of the two targets.
    • No page opens a new issue other than through the form.
    • Each offer page gives both ways to apply.
    • Every link whose text says "waitlist" goes to the email or to #waitlist.

The landing and pricing rewrite uses the same two targets.

Mutation check

Each mutant was applied, the tests were run, and the file was restored byte for byte. All 18 were killed.

Broken rule Killed by
form is not valid YAML FormIsAValidIssueForm, FormAsksWhatTheProgramNeeds
unknown field type (text) FormIsAValidIssueForm, FormAsksWhatTheProgramNeeds
duplicate field id FormIsAValidIssueForm, FormAsksWhatTheProgramNeeds
dropdown without options FormIsAValidIssueForm, FormAsksWhatTheProgramNeeds
design-partner label removed FormAsksWhatTheProgramNeeds
email made required FormAsksWhatTheProgramNeeds
public warning removed FormAsksWhatTheProgramNeeds
CI options changed FormAsksWhatTheProgramNeeds
required field dropped (id renamed) FormAsksWhatTheProgramNeeds
team made optional FormAsksWhatTheProgramNeeds
config contact link not the email IssueTemplateConfigOffersTheEmailPath
an apply link names a missing template EveryApplyLinkPointsToAValidTarget
apply link to an in-page anchor EveryApplyLinkPointsToAValidTarget
an "open an issue" link via ?title= (no "apply" in its text) EveryApplyLinkPointsToAValidTarget
apply email to another address EveryApplyLinkPointsToAValidTarget, EveryOfferPageOffersBothWaysToApply
an offer page drops the email path EveryOfferPageOffersBothWaysToApply
a waitlist link to another page EveryWaitlistLinkPointsToAValidTarget
the waitlist email to another address EveryWaitlistLinkPointsToAValidTarget

Test plan

  • go test ./scripts/ passes.
  • Mutation check (table above).
  • npm run build in website/ passes (62 pages). The built pricing, Probe Cloud, guide and preview pages contain the form link, and no built page has an issues/new?title= link.
  • gofmt clean.
  • After merge: open the form on GitHub and confirm it renders (GitHub validates issue forms only on the default branch).

…n every page

An issue form (design-partner.yml, label design-partner) with the email path in config.yml; the pricing and Probe Cloud pages and the two docs pages offer Apply on GitHub and Apply by email; a test checks the form and every apply link.
@pbertsch
pbertsch requested a review from a team as a code owner November 17, 2026 04:13
@pbertsch
pbertsch merged commit e3e6e88 into main Nov 17, 2026
10 of 11 checks passed
pbertsch added a commit that referenced this pull request Nov 17, 2026
…est (#756)

## Summary

`TestEveryWaitlistLinkPointsToAValidTarget` (from #752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page.

The test still checks every waitlist link that exists: each must go to `mailto:support@alphawavesystems.com` or to `#waitlist`. A site with no waitlist link now passes. If the scan finds no links at all, `siteLinks` already catches it in `TestEveryApplyLinkPointsToAValidTarget`.

This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from #752 is still true.

## Mutation check

The two waitlist mutants from #752 are still killed. Each was applied to `pricing.astro` on main, the test run, and the file restored byte for byte.

| Broken rule | Result |
|---|---|
| a waitlist link to another page | killed |
| the waitlist email to another address | killed |

## Test plan

- [x] The site's form and link tests in `go test ./scripts/` pass on main.
- [x] The same tests pass on the pricing rewrite's pages (no waitlist link) with main's docs and issue templates.
- [x] `gofmt` clean.
jay23606 added a commit to jay23606/flutter-probe that referenced this pull request Nov 17, 2026
…est (AlphaWaveSystems#756)

## Summary

`TestEveryWaitlistLinkPointsToAValidTarget` (from AlphaWaveSystems#752) also failed when the site had no waitlist link at all. The pricing rewrite removes the waitlist, so that condition would fail a correct page.

The test still checks every waitlist link that exists: each must go to `mailto:support@alphawavesystems.com` or to `#waitlist`. A site with no waitlist link now passes. If the scan finds no links at all, `siteLinks` already catches it in `TestEveryApplyLinkPointsToAValidTarget`.

This is a test-only change, so there's no CHANGELOG entry. The CHANGELOG line from AlphaWaveSystems#752 is still true.

## Mutation check

The two waitlist mutants from AlphaWaveSystems#752 are still killed. Each was applied to `pricing.astro` on main, the test run, and the file restored byte for byte.

| Broken rule | Result |
|---|---|
| a waitlist link to another page | killed |
| the waitlist email to another address | killed |

## Test plan

- [x] The site's form and link tests in `go test ./scripts/` pass on main.
- [x] The same tests pass on the pricing rewrite's pages (no waitlist link) with main's docs and issue templates.
- [x] `gofmt` clean.
pbertsch added a commit that referenced this pull request Nov 17, 2026
…eet, saying only what a client can do today (#753)

## Summary

The landing page, the pricing page and the Probe Cloud page are rewritten to say only what a client can do today, and they and the legal pages now share one stylesheet.

- **One stylesheet and one frame.** `website/src/styles/site.css` (the landing page's tokens: `#06080d`, accent `#3bf0e4`, Plus Jakarta Sans and JetBrains Mono) and `website/src/layouts/Site.astro` (head, nav, footer) replace four copies of inline CSS. `Legal.astro` uses the frame, so terms, privacy, refunds and contact move onto the same tokens with their text unchanged.
- **Landing page.** Hero with "Install free" and "Apply as a design partner"; a real test beside its real report (excerpts from real runs of the repository's own fixture app on an Android emulator: the left listing is a whole test, the six passing lines are one run of that file, and the failing block comes from a separate run of a variant file written to fail, with one repeated prefix trimmed from its message); three ways in (Free, design partner, Team or Scale) and what happens after each; a Probe Cloud section that lists only what the sample dashboard shows; the plans; three steps with the exact commands (the third is `--upload-dry-run`, which works today and sends nothing); an FAQ with data, cancel and refunds as policy links, non-GitHub CI, and what a design partner is. The existing benchmark claim keeps its method link. The footer adds Subprocessors and Company.
- **Pricing.** Free ($0), Team ($49 a month), Scale ($149 a month): unlimited seats, no overage, results a month on each card (1,000 / 100,000 / 500,000). Team and Scale are labelled "Planned, by invitation" and have no buy button and no annual price. A planned **On-The-Go (pay what you use)** card has no price and no button and says it is billed separately from the plans and is not available yet. Removed: the pay-per-use waitlist card and its mailto, the unbuilt Team features (roles, Slack and email notifications, parallel orchestration, priority support) and the "Cancel any time" line. The design-partner box is now the primary action (the offer is unchanged: first 10 teams, free during the beta, 50% off for life when paid plans launch, the beta may change or end).
- **Apply links** go only to the GitHub issue form (`.github/ISSUE_TEMPLATE/design-partner.yml?template=...`) and `mailto:support@alphawavesystems.com`.
- **Probe Cloud page.** On the shared frame; the dashboard section now matches the sample dashboard (daily pass rate, failing tests, unstable tests, newest commit of each pull request); "notifications" is gone from the planned list; it says uploads are built for GitHub Actions only. The sentence that the hosted service is not live is kept.
- **JSON-LD** stays the free offer only; no Offer for Team or Scale. No script, cookie or analytics added (the only script is the Copy button of the install box).

## Checked

- `npm run build` in `website/`: 62 pages built. `make ci-local`: 5 of 5 required checks.
- Browser (Chrome, local preview of the build): no console errors; the only third-party requests are Google Fonts, as on the landing page before. At **400 px** wide, `scrollWidth` equals 400 on the landing, pricing, Probe Cloud, terms, privacy, refunds and contact pages (a first run found 481 px on the landing page, from the install box in a grid, fixed); on desktop the landing page has no horizontal overflow.
- A text scan of the built pages: none of "gate", Slack, notifications, roles, priority support, pay-per-use, "cancel any time", annual prices, HTTP 402 or "autonomous" on the landing, pricing or Probe Cloud pages; every link whose text says "apply" goes to one of the two targets above.

## Not checked / limits

- **Dark only.** These pages had no light theme before and none is added.
- **Claims sourced from the repository:** "7 migration formats" is the seven rows of `website/src/content/docs/tools/probe-convert.md` (Maestro, Gherkin, Robot Framework, Detox, Appium Python, Java and JS). The "15MB binary" tag and "forever" on the Free price had no source and are removed (the installed 0.26.1 binary measures 12.0 MiB). The benchmark claim keeps its link to the method post.
- **Contrast and focus were checked by tools, not by hand:** axe-core 4.10.0 (WCAG 2 A and AA, 2.1 AA and best-practice rules) reports 0 violations on the landing, pricing, Probe Cloud, terms, privacy, refunds and contact pages at 1280 px and at 400 px (the landing page with the FAQ opened); every focusable element has an outline when focused, and a real Tab-key press shows the ring on the nav. axe found two real problems on the first run, both fixed: links inside text were told from the text by colour alone (now underlined) and scrollable code blocks could not be reached by keyboard (now focusable regions with their own labels). The desktop width of the browser window measured 1728 px, not exactly 1280 px (the 1280 px axe run used a 1280 px frame).
- **Fonts:** the pricing, Probe Cloud and legal pages now request Google Fonts too (the landing page already did).
- **Merged with main after the application form (#752) and the Subprocessors and Company pages (#749) landed:** the footer links `/subprocessors/` and `/company/` resolve to built pages, and `Legal.astro` keeps the `updated` and `noindex` props those pages use (Site.astro writes the robots meta): the built Subprocessors and Company pages read "Draft, not yet in effect", carry the draft banner and `<meta name="robots" content="noindex">`, and the other legal pages read "Last updated: 10 October 2026" as on main. `scripts/site_draft_pages_test.go` guards this (4 mutants killed). After the rebase axe-core reports 0 violations on the nine pages at 1280 px and at 400 px, with no horizontal scroll and a focus outline on every focusable element. The site truth check (`npm run check:truth`) is not on `main` yet, so it was not run.
- **Claims to confirm before merge:** the allowances (Free 1,000, Team 100,000, Scale 500,000 results a month) are planned allowances; they are not defined in this repository.
- `terms.astro` uses the word "apply" in its legal text and `refunds.astro` says "Cancel any time"; both are drafts waiting for review and are not touched here.
- Not run: iOS or Android devices (website only).

## Test plan

- [x] `npm run build` (website)
- [x] `make ci-local` 5 of 5, disclosure scan clean
- [x] 400 px: no horizontal scroll on the seven pages; desktop screenshot of the landing page
- [x] axe-core: 0 violations on the seven pages at 1280 px and 400 px; focus ring seen on a Tab press
- [ ] Review of every claim against the built pages
- [x] Footer links to Subprocessors and Company are built pages (checked in the build output); every link of every page was not clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant