Repository navigation
Conversation
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
Member
|
Thank you for this. We merged it with current main and checked each place the platform value feeds (device settings, run metadata, device view, crash hint); it holds up and the new test fails if the old behaviour returns. It needs a rebase on main (there is a one-line conflict next to a newly added build-info line in Studio: keep both) and the CLA check is failing: please complete it following its instructions. Then we will merge it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
ConnectWiFigave every WiFi connection the platform iOS. Neither the agent's handshake nor its mDNS record carries a platform, so Studio had no basis for that value. The status and the status line then showed iOS for an Android phone.The change
unknown.PlatformIOS, because the runner picks its platform-specific steps from it. A comment at the call site says the status and the device context can differ for a WiFi connection.TestConnectWiFiDoesNotReportIOSinstudio/wifi_platform_test.go.How it was tested
cd studio && go test -count=1 -run '^TestConnectWiFiDoesNotReportIOS$' -v .fails on the base commit withplatform "ios", want "unknown"and passes with the fix.go vet .instudio/reports no findings.go test -count=1 .instudio/fails.Run under WSL Debian.
Regression test: fails on base twice (/platform "ios", want "unknown"/), passes on fix twice (
cd studio && go test -count=1 -run '^TestConnectWiFiDoesNotReportIOS$' -v .)Fixes #400