Skip to content

fix(studio): a WiFi connection reports an unknown platform, not iOS - #670

Open
jay23606 wants to merge 1 commit into
AlphaWaveSystems:mainfrom
jay23606:pr-go/400-studio-a-wifi-connection-is-always-repor
Open

jay23606 wants to merge 1 commit into
AlphaWaveSystems:mainfrom
jay23606:pr-go/400-studio-a-wifi-connection-is-always-repor

Conversation

@jay23606

Copy link
Copy Markdown

The bug

ConnectWiFi gave every WiFi connection the platform iOS. Neither the agent's handshake nor its mDNS record carries a platform, so Studio had no basis for that value. The status and the status line then showed iOS for an Android phone.

The change

  • The WiFi connection's reported platform is now unknown.
  • The device context keeps PlatformIOS, because the runner picks its platform-specific steps from it. A comment at the call site says the status and the device context can differ for a WiFi connection.
  • Regression test TestConnectWiFiDoesNotReportIOS in studio/wifi_platform_test.go.

How it was tested

  • cd studio && go test -count=1 -run '^TestConnectWiFiDoesNotReportIOS$' -v . fails on the base commit with platform "ios", want "unknown" and passes with the fix.
  • go vet . in studio/ reports no findings.
  • go test -count=1 . in studio/ fails.

Run under WSL Debian.

Regression test: fails on base twice (/platform "ios", want "unknown"/), passes on fix twice (cd studio && go test -count=1 -run '^TestConnectWiFiDoesNotReportIOS$' -v .)

Fixes #400

Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
@jay23606
jay23606 requested a review from a team as a code owner November 16, 2026 07:44
@pbertsch

Copy link
Copy Markdown
Member

Thank you for this. We merged it with current main and checked each place the platform value feeds (device settings, run metadata, device view, crash hint); it holds up and the new test fails if the old behaviour returns. It needs a rebase on main (there is a one-line conflict next to a newly added build-info line in Studio: keep both) and the CLA check is failing: please complete it following its instructions. Then we will merge it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio: a WiFi connection is always reported as iOS, including Android phones

2 participants