Repository navigation
Conversation
Member
|
Thank you for this. The change reads well and the new tests pass when merged with current main. Two things are needed before it can merge: please rebase on main (the CHANGELOG conflicts; keep both entries) and complete the CLA check, which is failing, following its instructions. Once both are done we will merge it. |
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
jay23606
force-pushed
the
pr-go/408-dial-timeout-error-should-say-how-long-i
branch
from
November 17, 2026 19:31
9d68811 to
2079f36
Compare
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
When the CLI cannot reach the agent in time, the dial error did not say how long it waited or which setting raises the wait. On a loaded host the agent can take longer than the default 30s to start listening after a fresh install, and the failure then read as a bare
unexpected EOFori/o timeout, which looks like a protocol fault.The change
gave up after <wait> waiting for the agent; raise the wait with --dial-timeout or agent.dial_timeout in probe.yaml (default 30s), whatever the last error was.How it was tested
go test ./internal/probelink -run "TestDialGiveUpErrorNamesWaitAndSetting|TestDialGiveUpHintAfterEOFAndStall" -count=1 -vpasses. The first covers a refused connection and checks the wait is named once; the second covers an agent port that closes immediately (unexpected EOF) and one that accepts and never answers.go vet ./internal/probelinkandgo test ./internal/probelink -count=1pass.go test ./internal/probelink -run TestDialGiveUpErrorNamesWaitAndSetting -count=1 -vfails on the baseclient.gowith the new test file, and passes with the fix.Regression test: fails on base twice (/error should name the dial timeout setting/), passes on fix twice (
go test ./internal/probelink -run TestDialGiveUpErrorNamesWaitAndSetting -count=1 -v)Fixes #408