Repository navigation
fix(bench): isolate cells from upstream branches - #1621
Merged
AbirAbbas merged 2 commits intoSep 30, 2026
Merged
Conversation
|
|
Member
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
santoshkumarradha
added
bug
Contributor
Author
|
My bad, signed now! |
AbirAbbas
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
• Share one fetch-only working-tree helper across the benchmark runners
• Prevent benchmark cells from exposing upstream branches or newer gold-fix commits
• Add deterministic coverage for pinned commits, remote HEAD, reachable history, and benchmark wiring
• Ensure benchmark-only changes trigger the regression through
pr-readyHow it was checked
•
bash bench/canary/lib/repo_test.sh•
bash -n bench/run.sh bench/canary/lib/cell.sh bench/canary/lib/repo.sh bench/canary/lib/repo_test.sh bench/oneroad/lib/corpus.sh• Real fetch of benchmark base
6c978ffa1c49ba600c85eb893958409e37dbedd2: zero remote branches and one reachable commitCloses #1028