Skip to content

docs(manual): correct home standing-order due-time guidance - #1544

Merged
AbirAbbas merged 4 commits into
Agent-Field:devfrom
hy3560:fix/1469-home-manual
Sep 30, 2026
Merged

AbirAbbas merged 4 commits into
Agent-Field:devfrom
hy3560:fix/1469-home-manual

Conversation

@hy3560

@hy3560 hy3560 commented Sep 26, 2026

Copy link
Copy Markdown

What changed

Correct the Home manual: a waiting standing-order row does not show when it is next due. It now directs readers to open the standing place for the due time. Add retrieval and CLI regressions for the question that exposed the incorrect answer.

How it was checked

  • go build ./... — passed (Go 1.26.5).
  • go test ./internal/manual -count=1 — passed.
  • go vet ./internal/manual — passed.
  • go run ./cmd/codeaf manual "when does a standing order go off on home" — returned the corrected Home guidance.
  • The tagged e2e package cross-compiled for Linux. It could not be executed on this Windows host; the existing e2e harness uses Unix-only syscalls. Full go vet ./... likewise encounters unrelated Windows-only build/test issues.

Closes #1469.

@CLAassistant

CLAassistant commented Sep 26, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@santoshkumarradha

Copy link
Copy Markdown
Member

Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it?

hy3560 commented Sep 27, 2026

Copy link
Copy Markdown
Author

Thanks for the reminder. I have signed a CLA previously, but this PR's CLA Assistant check still shows not_signed. Could you confirm whether there is a project-specific CLA step or account association I need to complete if the PR-specific recheck does not update the status? I won't treat the CLA as complete until the check recognizes it.

@santoshkumarradha

Copy link
Copy Markdown
Member

Thanks for flagging this. We found that CodeAF wasn’t configured to share CLA signatures with our other repositories, and we’ve now enabled that. Your PR still shows the CLA as pending, though.

Could you open CodeAF’s CLA page while signed into GitHub as hy3560 and complete any signing prompt? Older repository-specific signatures may require signing once more. If it says you’ve already signed, please let us know which repository you originally signed for so we can investigate further.

cc @AbirAbbas

@santoshkumarradha santoshkumarradha added hygiene Tests, laws, dead code, duplication — no person-facing change area:chat The v3 surface a person sits in front of (internal/tui3) labels Sep 27, 2026
@santoshkumarradha santoshkumarradha added this to the Chat & connections milestone Sep 27, 2026

hy3560 commented Sep 29, 2026

Copy link
Copy Markdown
Author

Thanks for the clarification. I did sign a CLA previously, but I can’t reliably identify which repository I signed for. This PR conversation includes a CLA Assistant message saying all committers have signed, while your follow-up said the PR was still pending. Could you confirm whether the PR-specific check is now clear or whether a signing prompt is still required? I’ll wait for the check to show signed before treating this as complete.

dev added TestManualDescribesProviderKeyAndFirstModelFetch at the same place in
internal/manual/chat_test.go where this branch adds
TestHomeStandingOrderQuestionPointsToTheDueTimeDoor. Both tests are kept.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@AbirAbbas

Copy link
Copy Markdown
Collaborator

@hy3560 you're all set on the CLA: the check on this PR shows signed, so nothing more to do there. I merged the latest dev into your branch to clear a conflict in internal/manual/chat_test.go (dev added a test in the same spot; both are kept). CI is running on it now.

@AbirAbbas
AbirAbbas merged commit 4e9710a into Agent-Field:dev Sep 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:chat The v3 surface a person sits in front of (internal/tui3) hygiene Tests, laws, dead code, duplication — no person-facing change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Home manual promises a time at the right of waiting standing rows

4 participants