Repository navigation
docs(manual): correct home standing-order due-time guidance - #1544
Conversation
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
|
Thanks for the reminder. I have signed a CLA previously, but this PR's CLA Assistant check still shows |
|
Thanks for flagging this. We found that CodeAF wasn’t configured to share CLA signatures with our other repositories, and we’ve now enabled that. Your PR still shows the CLA as pending, though. Could you open CodeAF’s CLA page while signed into GitHub as cc @AbirAbbas |
|
Thanks for the clarification. I did sign a CLA previously, but I can’t reliably identify which repository I signed for. This PR conversation includes a CLA Assistant message saying all committers have signed, while your follow-up said the PR was still pending. Could you confirm whether the PR-specific check is now clear or whether a signing prompt is still required? I’ll wait for the check to show signed before treating this as complete. |
dev added TestManualDescribesProviderKeyAndFirstModelFetch at the same place in internal/manual/chat_test.go where this branch adds TestHomeStandingOrderQuestionPointsToTheDueTimeDoor. Both tests are kept. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@hy3560 you're all set on the CLA: the check on this PR shows signed, so nothing more to do there. I merged the latest |
What changed
Correct the Home manual: a waiting standing-order row does not show when it is next due. It now directs readers to open the standing place for the due time. Add retrieval and CLI regressions for the question that exposed the incorrect answer.
How it was checked
go build ./...— passed (Go 1.26.5).go test ./internal/manual -count=1— passed.go vet ./internal/manual— passed.go run ./cmd/codeaf manual "when does a standing order go off on home"— returned the corrected Home guidance.go vet ./...likewise encounters unrelated Windows-only build/test issues.Closes #1469.